m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1814100110
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStream.java:
##########
@@ -283,21 +312,105 @@ private void issueMultiChunkRequest(final long id,
PendingRequest pendingRequest
}
}
- private static class PendingRequest {
+ /**
+ * Returns true if the request should be failed due to stream shutdown, else
tracks the request to
+ * be sent and returns false.
+ */
+ private boolean isPrepareForSendFailed(long id, PendingRequest request) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
