m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1815671365
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStream.java:
##########
@@ -363,7 +363,7 @@ private void queueRequestAndWait(QueuedRequest request)
throws InterruptedExcept
QueuedBatch batch;
boolean responsibleForSend = false;
@Nullable QueuedBatch prevBatch = null;
- synchronized (batches) {
+ synchronized (shutdownLock) {
batch = batches.isEmpty() ? null : batches.getLast();
Review Comment:
done added (if shutdown throws) to everywhere we acquire the lock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
