arunpandianp commented on code in PR #32922:
URL: https://github.com/apache/beam/pull/32922#discussion_r1817704576
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/StreamingWorkerStatusReporter.java:
##########
@@ -228,6 +228,22 @@ private static void
shutdownExecutor(ScheduledExecutorService executor) {
}
}
+ // Calculates the PerWorkerMetrics reporting frequency, ensuring alignment
with the
Review Comment:
can we revert the unrelated change, to keep the diff small and on topic?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java:
##########
@@ -157,6 +157,19 @@ private static Optional<StreamingConfigTask>
fetchConfigWithRetry(
}
}
+ private static Optional<ComputationConfig>
createComputationConfig(StreamingConfigTask config) {
Review Comment:
can we revert the unrelated change, to keep the diff small and on topic?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -346,10 +348,7 @@ public static StreamingDataflowWorker
fromOptions(DataflowWorkerHarnessOptions o
.setSizeMb(options.getWorkerCacheMb())
.setSupportMapViaMultimap(options.isEnableStreamingEngine())
.build();
- Function<String, ScheduledExecutorService> executorSupplier =
- threadName ->
- Executors.newSingleThreadScheduledExecutor(
Review Comment:
I think changing `Executors.newSingleThreadScheduledExecutor` to
`Executors.newSingleThreadExecutor` should fix the problem? We don't need to
introduce a new Executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
