m-trieu commented on code in PR #32922:
URL: https://github.com/apache/beam/pull/32922#discussion_r1819588611
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -346,10 +348,7 @@ public static StreamingDataflowWorker
fromOptions(DataflowWorkerHarnessOptions o
.setSizeMb(options.getWorkerCacheMb())
.setSupportMapViaMultimap(options.isEnableStreamingEngine())
.build();
- Function<String, ScheduledExecutorService> executorSupplier =
- threadName ->
- Executors.newSingleThreadScheduledExecutor(
Review Comment:
We need `ScheduledExecutorService` here and
`Executors.newSingleThreadExecutor` does not return a `ScheduledExecutorService`
Question here:
do we want active work refresh failures to crash the JVM? if yes than we
need a terminating executor, if not i think we can remove
`TerminatingExecutors`, use `Executors.newSingleThreadExecutor` everywhere we
want a failure to crash the JVM and `ScheduledExecutorService` everywhere we
are ok with failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
