jrmccluskey commented on code in PR #32880:
URL: https://github.com/apache/beam/pull/32880#discussion_r1824705303
##########
sdks/python/apache_beam/transforms/ptransform.py:
##########
@@ -939,7 +938,21 @@ def element_type(side_input):
bindings = getcallargs_forhints(argspec_fn, *arg_types, **kwargs_types)
hints = getcallargs_forhints(
argspec_fn, *input_types[0], **input_types[1])
- for arg, hint in hints.items():
+ arg_hints = iter(hints.items())
+ element_arg, element_hint = next(arg_hints)
+ if not typehints.is_consistent_with(
+ bindings.get(element_arg, typehints.Any), element_hint):
+ transform_nest_level = self.label.count("/")
+ split_producer_label = pvalueish.producer.full_label.split("/")
+ producer_label = "/".join(
+ split_producer_label[:transform_nest_level + 1])
+ raise TypeCheckError(
+ f"The transform '{self.label}' requires "
+ f"PCollections of type '{element_hint}' "
+ f"but was applied to a PCollection of type"
+ f" '{bindings[element_arg]}' "
+ f"(produced by the transform '{producer_label}'). ")
Review Comment:
Is there a reason this type check is done up here rather than modifying the
check nested in the for loop? It looks kind of redundant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
