hjtran commented on code in PR #32880:
URL: https://github.com/apache/beam/pull/32880#discussion_r1825302468
##########
sdks/python/apache_beam/transforms/ptransform_test.py:
##########
@@ -2128,14 +2096,10 @@ def test_mean_globally_pipeline_checking_violated(self):
self.p
| 'C' >> beam.Create(['test']).with_output_types(str)
| 'Mean' >> combine.Mean.Globally())
-
- expected_msg = \
- "Type hint violation for 'CombinePerKey': " \
- "requires Tuple[TypeVariable[K], Union[<class 'float'>, <class 'int'>, "
\
- "<class 'numpy.float64'>, <class 'numpy.int64'>]] " \
- "but got Tuple[None, <class 'str'>] for element"
-
- self.assertStartswith(e.exception.args[0], expected_msg)
Review Comment:
This and one of the other messages got too hard/frustrating to update to use
with regex, so I just did some basic spot checking. The number of cases that
the new asserts wouldn't catch but the old would I think are pretty few.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
