jackdingilian commented on code in PR #33001:
URL: https://github.com/apache/beam/pull/33001#discussion_r1827908791


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -2351,6 +2355,22 @@ public ReadChangeStream 
withBacklogReplicationAdjustment(Duration adjustment) {
       return toBuilder().setBacklogReplicationAdjustment(adjustment).build();
     }
 
+    /**
+     * Returns a new {@link BigtableIO.ReadChangeStream} that overrides 
timeout for ReadChangeStream
+     * requests.
+     *
+     * <p>This is useful to override the default of 15s timeout if the 
checkpoint duration is longer
+     * than 15s. Setting this value to longer than periodic checkpoint 
duration ensures that

Review Comment:
   Maybe we should note that you probably want to add some padding beyond 
checkpoint duration to avoid deadline exceeded when checkpointing is slow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to