Abacn commented on code in PR #32988:
URL: https://github.com/apache/beam/pull/32988#discussion_r1828659455
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -799,6 +810,11 @@ public ReadRows withOutputParallelization(boolean
outputParallelization) {
return
toBuilder().setOutputParallelization(outputParallelization).build();
}
+ /** Whether to disable auto commit on read. Defaults to true if not
provided. */
Review Comment:
Could you please elaborate javadoc. For example, noting that some Jdbc
provider does not support setAutoCommit, which is the circumstance one needs to
set this to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
