Abacn commented on code in PR #32988:
URL: https://github.com/apache/beam/pull/32988#discussion_r1835193469
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -65,6 +65,7 @@ public Schema configurationSchema() {
.addNullableField("readQuery", FieldType.STRING)
.addNullableField("writeStatement", FieldType.STRING)
.addNullableField("fetchSize", FieldType.INT16)
+ .addNullableField("disableAutoCommit", FieldType.BOOLEAN)
Review Comment:
from the history this is likely to break python jdbcIO (based on schemaIO),
see #26480
Consider either revert the change of JdbcSchemaIOProvider.java or add the
same field to jdbc.py and same order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
