ahmedabu98 commented on code in PR #31486:
URL: https://github.com/apache/beam/pull/31486#discussion_r1831387135
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java:
##########
@@ -134,53 +141,62 @@ private Map<String, Object> resolveUnderlyingConfig() {
return YamlUtils.yamlStringToMap(yamlTransformConfig);
}
+
+ @VisibleForTesting
+ ManagedConfig resolveUnderlyingTransform(PCollectionRowTuple input) {
Review Comment:
Makes sense, I like that better.
I moved the logic to BQ side, PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
