ahmedabu98 commented on code in PR #31486:
URL: https://github.com/apache/beam/pull/31486#discussion_r1831617226


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryFileLoadsWriteSchemaTransformProvider.java:
##########
@@ -61,7 +60,7 @@ protected SchemaTransform from(BigQueryWriteConfiguration 
configuration) {
 
   @Override
   public String identifier() {
-    return 
getUrn(ExternalTransforms.ManagedTransforms.Urns.BIGQUERY_FILE_LOADS);
+    return "beam:schematransform:org.apache.beam:bigquery_fileloads:v1";

Review Comment:
   I feel like we don't need to right now? Since we're using a wrapper over 
file loads and storage api writes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to