ahmedabu98 commented on code in PR #31486:
URL: https://github.com/apache/beam/pull/31486#discussion_r1833531259
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryManagedIT.java:
##########
@@ -121,6 +153,8 @@ public void testStreamingStorageWriteRead() {
// streaming write
PCollectionRowTuple.of("input", getInput(writePipeline, true))
.apply(Managed.write(Managed.BIGQUERY).withConfig(config));
+ assertPipelineContainsTransformIdentifier(
+ writePipeline, new
BigQueryStorageWriteApiSchemaTransformProvider().identifier());
Review Comment:
> So the MANAGED_UNDERLYING_TRANSFORM_URN_KEY annotation of the "Managed"
transform will mention the top level BigQueryWriteSchemaTransform instead of
specific implementation for the write method, right ?
Hmmm good catch, I just switched it to mentioning the top level URN. This
means we lose information on what the underlying implementation is though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
