robertwb commented on code in PR #33027:
URL: https://github.com/apache/beam/pull/33027#discussion_r1833586117
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -876,8 +877,10 @@ def _parse_window_spec(spec):
return beam.WindowInto(window_fn)
@staticmethod
+ @beam.ptransform_fn
+ @maybe_with_exception_handling_transform_fn
Review Comment:
Do we expect this to every have errors (that we'd want to ignore)?
##########
sdks/python/apache_beam/yaml/examples/testing/examples_test.py:
##########
@@ -167,7 +225,8 @@ def _file_io_write_test_preprocessor(
transform['config'] = {
k: v
for k,
- v in transform.get('config', {}).items() if k.startswith('__')
+ v in transform.get('config', {}).items()
Review Comment:
Nit: do `for (k, v) in ...` to make this format better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
