Polber commented on code in PR #33027:
URL: https://github.com/apache/beam/pull/33027#discussion_r1834838864
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -876,8 +877,10 @@ def _parse_window_spec(spec):
return beam.WindowInto(window_fn)
@staticmethod
+ @beam.ptransform_fn
+ @maybe_with_exception_handling_transform_fn
Review Comment:
The only case for Python I can think of is if it is somehow not JSON
parseable (Possibly a custom provider upstream that does not return Row)
For Java, I could see there being other issues (for starters, doesn't ERROR
throw and exception when it logs?)
Regardless, this change was mostly for making it easier to hot-swap
LogForTesting in example pipelines that define error_handling Write transforms.
But I could also create a custom Log transform within the examples test file if
you think that makes more sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
