bzablocki commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1838124248
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java:
##########
@@ -998,7 +999,12 @@ public Write<T>
withSessionServiceFactory(SessionServiceFactory factory) {
return toBuilder().setSessionServiceFactory(factory).build();
}
- abstract int getMaxNumOfUsedWorkers();
+ /** todo docs */
+ public Write<T> withErrorHandler(ErrorHandler<BadRecord, ?> errorHandler) {
+ return toBuilder().setErrorHandler(errorHandler).build();
+ }
Review Comment:
> is there a place in this class where get* and with* methods are grouped?
This seems out of place to me.
I'm not sure if I understand your comment. The get* methods are below
grouped together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
