bzablocki commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1838128686
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java:
##########
@@ -1079,21 +1089,11 @@ public SolaceOutput expand(PCollection<T> input) {
MapElements.into(TypeDescriptor.of(Solace.Record.class))
.via(checkNotNull(getFormatFunction())));
- // Store the current window used by the input
- PCollection<Solace.PublishResult> captureWindow =
- records.apply("Capture window", ParDo.of(new
RecordToPublishResultDoFn()));
-
- @SuppressWarnings("unchecked")
- WindowingStrategy<Solace.PublishResult, BoundedWindow> windowingStrategy
=
- (WindowingStrategy<Solace.PublishResult, BoundedWindow>)
- captureWindow.getWindowingStrategy();
-
PCollection<Solace.Record> withGlobalWindow =
records.apply("Global window", Window.into(new GlobalWindows()));
PCollection<KV<Integer, Solace.Record>> withShardKeys =
- withGlobalWindow.apply(
- "Add shard key", ParDo.of(new
AddShardKeyDoFn(getMaxNumOfUsedWorkers())));
+ withGlobalWindow.apply("Add shard key", ParDo.of(new
AddShardKeyDoFn(getNumShards())));
Review Comment:
Agreed. We can add GroupIntoBatches in a separate pull request to avoid
delaying this one. This ensures we can proceed without being held up by the
GroupIntoBatches implementation, especially since it doesn't affect the public
API.
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java:
##########
@@ -119,7 +122,7 @@ public MessageReceiver getReceiver() {
}
@Override
- public MessageProducer getProducer(SubmissionMode submissionMode) {
+ public MessageProducer getInitializeProducer(SubmissionMode submissionMode) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
