m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1841018880
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStreamTest.java:
##########
@@ -131,13 +136,27 @@ public void testShutdown_abortsQueuedCommits() throws
InterruptedException {
commitProcessed.countDown();
});
}
+ } catch (StreamObserverCancelledException ignored) {
}
// Verify that we sent the commits above in a request + the initial header.
- verify(requestObserver,
times(2)).onNext(any(Windmill.StreamingCommitWorkRequest.class));
+ verify(requestObserver, times(2))
+ .onNext(
+ argThat(
+ request -> {
+ if (request.getHeader().equals(TEST_JOB_HEADER)) {
Review Comment:
done used inorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
