m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1841042910
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/observers/DirectStreamObserver.java:
##########
@@ -83,16 +85,14 @@ public void onNext(T value) throws
StreamObserverCancelledException {
// Phaser is terminated so don't use the outboundObserver. Since
onError and onCompleted
// are synchronized after terminating the phaser if we observe that
the phaser is not
// terminated the onNext calls below are guaranteed to not be called
on a closed observer.
- if (currentPhase < 0) return;
+ if (currentPhase < 0) {
+ throw new StreamObserverCancelledException("StreamObserver was
terminated.");
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
