m-trieu commented on code in PR #33187:
URL: https://github.com/apache/beam/pull/33187#discussion_r1859101106
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -195,7 +199,10 @@ static FanOutStreamingEngineWorkerHarness forTesting(
getWorkBudgetDistributor,
dispatcherClient,
workCommitterFactory,
- getDataMetricTracker);
+ getDataMetricTracker,
+ // Run the workerMetadataConsumer on the direct calling thread to
make testing more
+ // deterministic.
Review Comment:
In prod, this is to hand off the task from a thread that (may) perform
network IO and we do not want the task to block that since it acquires a lock
to do its work. Not needed in testing and can logically be called in line
Added comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
