m-trieu commented on code in PR #33187:
URL: https://github.com/apache/beam/pull/33187#discussion_r1859111305
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/ChannelCache.java:
##########
@@ -85,7 +86,9 @@ static ChannelCache forTesting(
notification -> {
shutdownChannel(notification.getValue());
onChannelShutdown.run();
- });
+ },
+ // Run the removal on the calling thread for better determinism in
tests.
Review Comment:
added, this doesn't change any behavior we just want the removal to run
synchronously so we don't have to rely on waiting in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
