prodriguezdefino commented on code in PR #32878:
URL: https://github.com/apache/beam/pull/32878#discussion_r1866368002
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2550,7 +2577,7 @@ def __init__(
use_at_least_once=False,
with_auto_sharding=False,
num_storage_api_streams=0,
- use_cdc_writes: bool = False,
+ use_cdc_writes: UseCdcWrites = False,
Review Comment:
> I'll also note that this parameter is now very overloaded. I'd probably
prefer an extra param here over repurposing this one.
We have similar overloads in this same file, see
[here](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L972)
and also we have other instances on where the overload is silently added on a
[typeless
argument](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L2571).
The strict type definition simplifies the understanding of the shape for the
argument, and to some degree the validations made later (would have been even
simpler and more strict with Python > 3.10).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
