damccorm commented on code in PR #32878:
URL: https://github.com/apache/beam/pull/32878#discussion_r1866185236
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2550,7 +2577,7 @@ def __init__(
use_at_least_once=False,
with_auto_sharding=False,
num_storage_api_streams=0,
- use_cdc_writes: bool = False,
+ use_cdc_writes: UseCdcWrites = False,
Review Comment:
Could you add some more context on why we need this PR? What use case is it
enabling which previously was impossible/is there a reason having this as a
parameter is better than just recommending users do preprocessing before the
write step? As much as we can, I'd prefer to keep custom user code out of the
IO for debugability.
I'll also note that this parameter is now very overloaded. I'd probably
prefer an extra param here over repurposing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
