twosom opened a new pull request, #33322: URL: https://github.com/apache/beam/pull/33322
**Please** add a meaningful description for your change here fixes #20943 This PR improves the performance of GroupByKey transform in SparkRunner by replacing the current implementation that uses Spark's `groupByKey` with `combineByKey`. The current implementation uses Spark's `groupByKey` which causes all the data to be shuffled across the network before grouping. This can lead to significant performance overhead and potential OOM issues with large datasets. By switching to Spark's `combineByKey`, we can: - Perform partial combining at the map side before shuffling - Reduce the amount of data transferred across the network - Improve memory utilization and overall performance ## Before optimized - `6.1GiB` for shuffle <img width="1257" alt="스크린샷 2024-12-08 오후 7 42 03" src="https://github.com/user-attachments/assets/871f066c-3802-425e-80e1-119edd6d3e19";> ## After optimized - `1487.7MiB` for shuffle. <img width="1250" alt="스크린샷 2024-12-08 오후 9 22 45" src="https://github.com/user-attachments/assets/53b5197d-6df4-42bc-9c8a-7494ee8d6b47";> ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
