damccorm commented on code in PR #33322:
URL: https://github.com/apache/beam/pull/33322#discussion_r1884006707
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/GroupNonMergingWindowsFunctionsTest.java:
##########
@@ -121,54 +112,6 @@ public void testGbkIteratorValuesCannotBeReiterated()
throws Coder.NonDeterminis
}
}
- @Test
- @SuppressWarnings({"rawtypes", "unchecked"})
- public void testGroupByKeyInGlobalWindowWithPartitioner() {
- // mocking
- Partitioner mockPartitioner = mock(Partitioner.class);
- JavaRDD mockRdd = mock(JavaRDD.class);
- Coder mockKeyCoder = mock(Coder.class);
- Coder mockValueCoder = mock(Coder.class);
- JavaPairRDD mockRawKeyValues = mock(JavaPairRDD.class);
- JavaPairRDD mockGrouped = mock(JavaPairRDD.class);
-
- when(mockRdd.mapToPair(any())).thenReturn(mockRawKeyValues);
- when(mockRawKeyValues.groupByKey(any(Partitioner.class)))
- .thenAnswer(
- invocation -> {
- Partitioner partitioner = invocation.getArgument(0);
- assertEquals(partitioner, mockPartitioner);
- return mockGrouped;
- });
- when(mockGrouped.map(any())).thenReturn(mock(JavaRDD.class));
-
- GroupNonMergingWindowsFunctions.groupByKeyInGlobalWindow(
- mockRdd, mockKeyCoder, mockValueCoder, mockPartitioner);
-
- verify(mockRawKeyValues, never()).groupByKey();
- verify(mockRawKeyValues, times(1)).groupByKey(any(Partitioner.class));
- }
-
- @Test
- @SuppressWarnings({"rawtypes", "unchecked"})
- public void testGroupByKeyInGlobalWindowWithoutPartitioner() {
- // mocking
- JavaRDD mockRdd = mock(JavaRDD.class);
- Coder mockKeyCoder = mock(Coder.class);
- Coder mockValueCoder = mock(Coder.class);
- JavaPairRDD mockRawKeyValues = mock(JavaPairRDD.class);
- JavaPairRDD mockGrouped = mock(JavaPairRDD.class);
-
- when(mockRdd.mapToPair(any())).thenReturn(mockRawKeyValues);
- when(mockRawKeyValues.groupByKey()).thenReturn(mockGrouped);
-
- GroupNonMergingWindowsFunctions.groupByKeyInGlobalWindow(
- mockRdd, mockKeyCoder, mockValueCoder, null);
-
- verify(mockRawKeyValues, times(1)).groupByKey();
- verify(mockRawKeyValues, never()).groupByKey(any(Partitioner.class));
Review Comment:
Oh I see - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
