damccorm commented on code in PR #33470: URL: https://github.com/apache/beam/pull/33470#discussion_r1901245998
########## .github/workflows/beam_Publish_Python_SDK_Distroless_Snapshots.yml: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Publish Beam Python SDK Distroless Snapshots + +on: + schedule: + - cron: '45 */8 * * *' + workflow_dispatch: + + #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event +permissions: + actions: write + pull-requests: read + checks: read + contents: read + deployments: read + id-token: none + issues: read + discussions: read + packages: read + pages: read + repository-projects: read + security-events: read + statuses: read + +# This allows a subsequently queued workflow run to interrupt previous runs +concurrency: + group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.sender.login }}' + cancel-in-progress: true + +env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} + GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} + docker_registry: gcr.io + +jobs: + Python_SDK_Distroless_Snapshots: Review Comment: Why is this list being long a problem? If you ignore the last 3 weeks, this workflow has been highly reliable. Its been very flaky the last 3 weeks because there is a real problem which needs to be addressed at high priority (it likely should not have been ignored this long, but I will blame the holidays there). There are workflows where occasional flakes are ok, but this isn't really one of them since we need this to all work together in order to release (as written today). So if all of these running together is failing often, that's a signal we need. If we want to split these out (which I think is wrong), we should refactor so that we're sharing as much logic as possible. But refactoring workflows just creates more things to maintain, it doesn't speed things up and it doesn't reduce the actual flakiness. Lastly, I'll note that having these in the same workflow is helpful because it is helpful for snapshot containers to be published together so that x-lang changes are reflected in both places -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
