damccorm commented on code in PR #33470: URL: https://github.com/apache/beam/pull/33470#discussion_r1901258133
########## .github/workflows/beam_Publish_Python_SDK_Distroless_Snapshots.yml: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Publish Beam Python SDK Distroless Snapshots + +on: + schedule: + - cron: '45 */8 * * *' + workflow_dispatch: + + #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event +permissions: + actions: write + pull-requests: read + checks: read + contents: read + deployments: read + id-token: none + issues: read + discussions: read + packages: read + pages: read + repository-projects: read + security-events: read + statuses: read + +# This allows a subsequently queued workflow run to interrupt previous runs +concurrency: + group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.sender.login }}' + cancel-in-progress: true + +env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} + GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} + docker_registry: gcr.io + +jobs: + Python_SDK_Distroless_Snapshots: Review Comment: Ok - why is it bad though? In general, these do the exact same thing, so I think having a single workflow makes a lot of sense. My view: **Pros of a single large workflow:** - 1 thing to monitor - Snapshots get published together at the same time, guaranteeing they will be taken for the same commit (this is actually pretty important IMO for a good x-lang story and making things easier to reason about) - Shared logic exists in a single place instead of being copied in many workflow definitions (could be mitigated by sharing logic across workflows) **Cons:** - Flakes are more likely to compound `Failure Rate = (individual failure rate)^(# jobs)` - I think this is fine (maybe even good) for a job that we want to have a flake rate approaching 0 - It is harder to iterate if you just want a single language launched - this is rare, and also we can make this happen in a single workflow definition via `if` conditions Are there pros/cons that I'm missing or do you value these things differently than me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
