ahmedabu98 commented on code in PR #33231:
URL: https://github.com/apache/beam/pull/33231#discussion_r1901886578
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -531,6 +532,30 @@ public void process(
element.getKey().getKey(), dynamicDestinations,
datasetService);
tableSchema = converter.getTableSchema();
descriptor = converter.getDescriptor(false);
+
+ if (autoUpdateSchema) {
Review Comment:
Correct, this `if` block would only be executed if we have not detected S'
yet.
But if S' is detected and stored in state, we would execute the first `if`
block (line 520 here) and use that stored value. We still end up using the
updated S', no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
