ahmedabu98 commented on code in PR #33231:
URL: https://github.com/apache/beam/pull/33231#discussion_r1901894033
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -531,6 +532,30 @@ public void process(
element.getKey().getKey(), dynamicDestinations,
datasetService);
tableSchema = converter.getTableSchema();
descriptor = converter.getDescriptor(false);
+
+ if (autoUpdateSchema) {
Review Comment:
Unless:
1. S is updated to S'
2. current writer recognizes it and stores S' in state
3. writer crashes for whatever reason
4. S' is updated to S''
5. new writer is created, using the schema stored in state: S'
This new writer would have no chance to recognize S'' because it was created
after that update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
