damondouglas commented on code in PR #33493:
URL: https://github.com/apache/beam/pull/33493#discussion_r1904522681
##########
sdks/go/pkg/beam/runners/prism/internal/engine/teststream.go:
##########
@@ -142,10 +142,8 @@ func (ts *testStreamHandler) UpdateHold(em
*ElementManager, newHold mtime.Time)
ts.currentHold = newHold
ss.watermarkHolds.Add(ts.currentHold, 1)
- // kick the TestStream and Impulse stages too.
+ // kick the TestStream stage to ensure downstream watermark propagation.
Review Comment:
'Kick' signals the element manager to integrate the intent of the
testStreamHandler's watermark settings under test with related stages'
watermark. In other words, if there are remaining elements in test stream, we
prevent prematurely setting all the stages' output watermark to infinity. The
underlying mechanism by which we signal i.e. 'kick' is to merge the
testStreamHandler's ID to the element manager's changedStages property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
