lostluck commented on code in PR #33493:
URL: https://github.com/apache/beam/pull/33493#discussion_r1904532402
##########
sdks/go/pkg/beam/runners/prism/internal/engine/teststream.go:
##########
@@ -142,10 +142,8 @@ func (ts *testStreamHandler) UpdateHold(em
*ElementManager, newHold mtime.Time)
ts.currentHold = newHold
ss.watermarkHolds.Add(ts.currentHold, 1)
- // kick the TestStream and Impulse stages too.
+ // kick the TestStream stage to ensure downstream watermark propagation.
Review Comment:
That's right.
Like when you kick a ball, or engage in percussive maintenance on any
mechanical device, this "kick" gets the Element Manager moving again, by saying
a stage needs to be evaluated, and as it says, to ensure downstream watermark
propagation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
