robertwb commented on code in PR #33587:
URL: https://github.com/apache/beam/pull/33587#discussion_r1915465199
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
@@ -485,7 +485,7 @@ public WriteResult
expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
// loading.
PCollectionTuple partitions =
results
- .apply("ReifyResults", new ReifyAsIterable<>())
+ .apply("ReifyResults", new CombineAsIterable<>())
Review Comment:
This won't have any output for an empty PCollection (whereas ReifyAsIterable
does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
