Abacn commented on code in PR #33587:
URL: https://github.com/apache/beam/pull/33587#discussion_r1915494633
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
@@ -485,7 +485,7 @@ public WriteResult
expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
// loading.
PCollectionTuple partitions =
results
- .apply("ReifyResults", new ReifyAsIterable<>())
+ .apply("ReifyResults", new CombineAsIterable<>())
Review Comment:
yes that's right, and it fails a unit test (changed below).
I'm not fully understand the implication of this behavior of change. One
thing I could wonder is that if a pipeline didn't have any input before, it
would still create an empty table; while now it does not.
Could this be a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
