tomstepp commented on code in PR #33591:
URL: https://github.com/apache/beam/pull/33591#discussion_r1919431625
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -139,6 +146,11 @@ public void finalizeCheckpoint() throws IOException {
// nothing to do
}
}
+
+ /* Get offset limit for unbounded source split checkpoint. */
+ default byte[] getOffsetLimit() {
Review Comment:
That sounds good. IIUC this means the default implementation would throw an
exception and the runner (StreamingModeExecutionContext for Dataflow) must only
call this method if the source enables offset deduplication. Updated PR to
match this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
