tomstepp commented on code in PR #33591:
URL: https://github.com/apache/beam/pull/33591#discussion_r1924343981
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillSink.java:
##########
@@ -215,7 +215,13 @@ public long add(WindowedValue<T> data) throws IOException {
.setMetadata(metadata);
keyedOutput.addMessages(builder.build());
keyedOutput.addMessagesIds(id);
- return (long) key.size() + value.size() + metadata.size() + id.size();
+
+ ByteString offset =
ByteString.copyFrom(context.getCurrentRecordOffset());
Review Comment:
Sounds good, updated to only allocate if non-zero offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
