ahmedabu98 commented on PR #33648:
URL: https://github.com/apache/beam/pull/33648#issuecomment-2605660488

   Hey @regadas, I skimmed over this and noticed that a large portion of this 
PR includes changes that are not update compatible. In general for streaming 
pipelines we try not to change the PCollection element type (more importantly, 
the coder) unless it's really necessary. Otherwise, streaming pipelines will 
break when trying to update to the newer SDK version
   
   It might be better to add a (static?) cache like @Abacn 
[suggested](https://github.com/apache/beam/pull/33575#issuecomment-2588258680)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to