chamikaramj commented on PR #33648: URL: https://github.com/apache/beam/pull/33648#issuecomment-2605887103
Hi @regadas, thanks again for this and other contributions :) To clarify, do the performance gains here come from eliminating per-element "TableIdentifier.parse(element.getKey())" calls or something else ? Also, do you have any idea of perf gains received through this approach compared to a caching based approach ? If pref gains are similar, I think it's preferable to not break update compatibility :) Also, as a side note, we heavily discourage using Java serialization for coders. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
