svetakvsundhar commented on code in PR #33701:
URL: https://github.com/apache/beam/pull/33701#discussion_r1924394798
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/RecordWriterManagerTest.java:
##########
@@ -465,6 +486,10 @@ public void testIdentityPartitioning() throws IOException {
.identity("float")
.identity("double")
.identity("str")
+ .identity("date")
Review Comment:
for my knowledge, it's unclear to me how `testIdentityPartitioning()` was
passing [when identity should support Any source
type](https://iceberg.apache.org/spec/#partition-transforms). Is it worth
adding an integration test to ensure just the `Write` works when partitioning
by just `date`, as well as `Any`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
