ahmedabu98 commented on code in PR #33701:
URL: https://github.com/apache/beam/pull/33701#discussion_r1926065648
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/RecordWriterManagerTest.java:
##########
@@ -465,6 +486,10 @@ public void testIdentityPartitioning() throws IOException {
.identity("float")
.identity("double")
.identity("str")
+ .identity("date")
Review Comment:
This test used to not include `date` and the other time types. This PR adds
adds them to the test (your comment is actually positioned on the lines that
add them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
