stankiewicz commented on code in PR #33780:
URL: https://github.com/apache/beam/pull/33780#discussion_r1939084138
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java:
##########
@@ -138,15 +157,19 @@ public boolean hasNext() {
public T next() {
T value = wrappedIterator.next();
try {
- elementCoder.registerByteSizeObserver(value, observerProxy);
- if (observerProxy.getIsLazy()) {
- // The observer will only be notified of bytes as the result
- // is used. We defer advancing the observer until hasNext in an
- // attempt to capture those bytes.
- observerNeedsAdvance = true;
- } else {
- observerNeedsAdvance = false;
- observerProxy.advance();
+ if (sampleElement() ||
elementCoder.isRegisterByteSizeObserverCheap(value)) {
Review Comment:
done. I will fix OutputObjectAndByteCounter in next pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
