scwhittle commented on code in PR #33780:
URL: https://github.com/apache/beam/pull/33780#discussion_r1939108661


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java:
##########
@@ -105,6 +106,12 @@ private static class WrappedObservingIterator<T> extends 
ElementByteSizeObservab
 
     private boolean observerNeedsAdvance = false;
     private boolean exceptionLogged = false;
+    private final Random randomGenerator = new Random();

Review Comment:
   should we use ThreadLocalRandom?
   for dataflow streaming we have lots of bundles, and thus might have a lot of 
these if used for input.
   
   see https://github.com/apache/beam/pull/33737 for OutputObjectAndByteCounter 
change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to