kennknowles commented on code in PR #33840:
URL: https://github.com/apache/beam/pull/33840#discussion_r1940245715
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -965,8 +968,8 @@ message StandardCoders {
// 01 - on time
// 10 - late
// 11 - unknown
- // * bit 6 is 1 if this is the first pane, 0 otherwise.
- // * bit 7 is 1 if this is the last pane, 0 otherwise.
+ // * bit 6 is 1 if this is the last pane, 0 otherwise.
Review Comment:
OK I've read down and see that the Go implementation matches the Java
implementation (obvs it would have to) so maybe the best way to express this is
to name these by `byte | 0x01` and `byte | 0x02`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
