lostluck commented on code in PR #33840:
URL: https://github.com/apache/beam/pull/33840#discussion_r1940251723
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -965,8 +968,8 @@ message StandardCoders {
// 01 - on time
// 10 - late
// 11 - unknown
- // * bit 6 is 1 if this is the first pane, 0 otherwise.
- // * bit 7 is 1 if this is the last pane, 0 otherwise.
+ // * bit 6 is 1 if this is the last pane, 0 otherwise.
Review Comment:
Nope, but if you look at the Java and Python linkes (and the internal
Dataflow implementation) the updated text is correct. The IsFirst bit is the
last bit (index 7) in big endian order.
0b01234567 - indices
0b00000001 - IsFirst bit is true (0x01)
0b00000010 - IsLast bit is true (0x02)
I agree that the original text is more intuitive, but we can't change
Python, Java, and Dataflow. It's a small blessing that the Go SDK was the only
one impacted by this, and it turns out you can't even use panes properly there
either due to https://github.com/apache/beam/issues/31153.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
