shunping commented on code in PR #33319:
URL: https://github.com/apache/beam/pull/33319#discussion_r1940426161
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -1124,8 +1153,8 @@ def __init__(
transform, # type: Optional[ptransform.PTransform]
full_label, # type: str
main_inputs, # type: Optional[Mapping[str, Union[pvalue.PBegin,
pvalue.PCollection]]]
- environment_id=None, # type: Optional[str]
- annotations=None, # type: Optional[Dict[str, bytes]]
+ environment_id, # type: Optional[str]
Review Comment:
It seems that removing the default value for these two arguments causes some
internal test to fail (internal bug id: 394194442). Fortunately, it is trivial
to fix such tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
