robertwb commented on code in PR #33319: URL: https://github.com/apache/beam/pull/33319#discussion_r1940502486
########## sdks/python/apache_beam/pipeline.py: ########## @@ -1124,8 +1153,8 @@ def __init__( transform, # type: Optional[ptransform.PTransform] full_label, # type: str main_inputs, # type: Optional[Mapping[str, Union[pvalue.PBegin, pvalue.PCollection]]] - environment_id=None, # type: Optional[str] - annotations=None, # type: Optional[Dict[str, bytes]] + environment_id, # type: Optional[str] Review Comment: It's incorrect to leave these two out (and setting environment_id to None could have caused issues in some cases as well). Looking at an internal fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org