jrmccluskey commented on code in PR #33702: URL: https://github.com/apache/beam/pull/33702#discussion_r1941375599
########## sdks/python/apache_beam/testing/benchmarks/README.md: ########## @@ -0,0 +1,117 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Writing a Dataflow Cost Benchmark + +Writing a Dataflow Cost Benchmark to estimate the financial cost of executing a pipeline on Google Cloud Platform Dataflow requires 4 components in the repository: + +1. A pipeline to execute (ideally one located in the examples directory) +1. A text file with pipeline options in the `.github/workflows/cost-benchmarks-pipeline-options` [directory](../../../../../.github/workflows/cost-benchmarks-pipeline-options) +1. A test class inheriting from the `DataflowCostBenchmark` [class](../load_tests/dataflow_cost_benchmark.py) +1. An entry to execute the pipeline as part of the cost benchmarks workflow action + +### Choosing a Pipeline +Pipelines that are worth benchmarking in terms of performance and cost have a few straightforward requirements. + +1. The transforms used in the pipeline should be native to Beam *or* be lightweight and readily available in the given pipeline +1. The pipeline itself should run on a consistent data set and have consistent internals (such as model versions for `RunInference` workloads.) +1. The pipeline should perform some sort of behavior that would be common enough for a user to create themselves + * Effectively, we want to read data from a source, do some sort of transformation, then write that data elsewhere. No need to overcomplicate things. + +Additionally, the `run()` call for the pipeline should return a `PipelineResult` object, which the benchmark framework uses to query metrics from Dataflow after the run completes. + +### Pipeline Options +Once you have a functioning pipeline to configure as a benchmark, the options needs to be saved as a `.txt` file in the `.github/workflows/cost-benchmarks-pipeline-options` [directory](../../../../../.github/workflows/cost-benchmarks-pipeline-options). +The file needs the Apache 2.0 license header at the top of the file, then each flag will need to be provided on a separate line. These arguments include: + +* GCP Region (usually us-central1) +* Machine Type +* Number of Workers +* Disk Size +* Autoscaling Algorithm (typically `NONE` for benchmarking purposes) +* Staging and Temp locations +* A requirements file path in the repository (if additional dependencies are needed) +* Benchmark-specific values + * `publish_to_big_query` + * This is always `true` for cost benchmarks + * Metrics Dataset for Output + * For `RunInference` workloads this will be `beam_run_inference` + * Metrics Table for Output + * This should be named for the benchmark being run + +### Configuring the Test Class +With the pipeline itself chosen and the arguments set, we can build out the test class that will execute the pipeline. Navigate to [`sdks/python/apache_beam/testing/benchmarks`](../../testing/benchmarks/) and select an appropriate sub-directory (or create one if necessary.) +The class for `wordcount` is shown below: + +```py +import logging + +from apache_beam.examples import wordcount +from apache_beam.testing.load_tests.dataflow_cost_benchmark import DataflowCostBenchmark + + +class WordcountCostBenchmark(DataflowCostBenchmark): + def __init__(self): + super().__init__() + + def test(self): + extra_opts = {} + extra_opts['output'] = self.pipeline.get_option('output_file') + self.result = wordcount.run( + self.pipeline.get_full_options_as_args(**extra_opts), + save_main_session=False) + + +if __name__ == '__main__': + logging.basicConfig(level=logging.INFO) + WordcountCostBenchmark().run() +``` + +The important notes here: if there are any arguments with common arg names (like `input` and `output`) you can use the `extra_opts` dictionary to map to them from alternatives in the options file. + +You should also make sure that you save the output of the `run()` call from the pipeline in the `self.result` field, as the framework will try to re-run the pipeline without the extra opts if that value is missing. Beyond those two key notes, the benchmarking framework does all of the other work in terms of setup, teardown, and metrics querying. + +#### Streaming Workloads + +If the pipeline is a streaming use case, two versions need to be created: one operating on a backlog of work items (e.g. the entire test corpus is placed into the streaming source +before the pipeline begins) and one operating in steady state (e.g. elements are added to the streaming source at a regular rate.) The former is relatively simple, simply add an extra +step to the `test()` function to stage the input data into the streaming source being read from. For the latter, a separate Python thread should be spun up to stage one element at a time +repeatedly over a given time interval (the interval between elements and the duration of the staging should be defined as part of the benchmark configuration.) Once the streaming pipeline +is out of data and does not receive more for an extended period of time, the pipeline will exit and the benchmarking framework will process the results in the same manner as the batch case. +In the steady state case, remember to call `join()` to close the thread after exectution. + +### Updating the Benchmark Workflow +Navigate to [`.github/workflows/beam_Python_CostBenchmarks_Dataflow.yml`](../../../../../.github/workflows/beam_Python_CostBenchmarks_Dataflow.yml) and make the following changes: + +1. Add the pipeline options `.txt` file written above to the `argument-file-paths` list. This will load those pipeline options as an entry in the workflow environment, with the entry getting the value `env.beam_Python_Cost_Benchmarks_Dataflow_test_arguments_X`. X is an integer value corresponding to the position of the text file in the list of files, starting from `1`. +2. Create an entry for the benchmark. The entry for wordcount is as follows: + +```yaml + - name: Run wordcount on Dataflow + uses: ./.github/actions/gradle-command-self-hosted-action + timeout-minutes: 30 Review Comment: If the run times out the workflow itself will fail, so we'd get a surfaced error in GitHub. The metrics would likely never surface in that situation, since the workflow is more likely stuck in the pipeline step rather than the metrics gathering/writing step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
