jrmccluskey commented on code in PR #33702: URL: https://github.com/apache/beam/pull/33702#discussion_r1941439277
########## sdks/python/apache_beam/testing/benchmarks/README.md: ########## @@ -29,8 +29,13 @@ Writing a Dataflow Cost Benchmark to estimate the financial cost of executing a ### Choosing a Pipeline Pipelines that are worth benchmarking in terms of performance and cost have a few straightforward requirements. -1. The transforms used in the pipeline should be native to Beam *or* be lightweight and readily available in the given pipeline -1. The pipeline itself should run on a consistent data set and have consistent internals (such as model versions for `RunInference` workloads.) +1. The transforms used in the pipeline should be native to Beam *or* be lightweight and contain their source code in the pipeline code. \ Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
