robertwb commented on code in PR #33474:
URL: https://github.com/apache/beam/pull/33474#discussion_r1943352418
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/MetricsToCounterUpdateConverter.java:
##########
@@ -111,6 +118,46 @@ public static CounterUpdate fromStringSet(
.setStringList(stringList);
}
+ public static CounterUpdate fromBoundedTrie(
+ MetricKey key, boolean isCumulative, BoundedTrieData boundedTrieData) {
+ // BoundedTrie uses SET kind metric aggregation which tracks unique
strings as a trie.
Review Comment:
This doesn't seem correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
