rohitsinha54 commented on code in PR #33474:
URL: https://github.com/apache/beam/pull/33474#discussion_r1943398739
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/MetricsToCounterUpdateConverter.java:
##########
@@ -111,6 +118,46 @@ public static CounterUpdate fromStringSet(
.setStringList(stringList);
}
+ public static CounterUpdate fromBoundedTrie(
+ MetricKey key, boolean isCumulative, BoundedTrieData boundedTrieData) {
+ // BoundedTrie uses SET kind metric aggregation which tracks unique
strings as a trie.
Review Comment:
I was just looking in that if we can omit it and still cook up something
internally to work.
This is only used on router translation logic when we translate from
CounterUpdate to Aggregation to determine combiner type:
1.
https://source.corp.google.com/piper///depot/google3/cloud/dataflow/router/translation/v1beta3.cc;l=1384
2.
https://source.corp.google.com/piper///depot/google3/cloud/dataflow/router/translation/v1beta3.cc;l=1083
For BoundedTrie at least for now we don't need kind switch as we have only
one kind.
I do not have a strict preference either ways on this one. Let me know if
you prefer one way over the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
