trucleduc commented on a change in pull request #12721:
URL: https://github.com/apache/beam/pull/12721#discussion_r482385851
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -122,12 +124,24 @@
* store) This requires each resource to contain a client provided ID. It is
important that when
* using import you give the appropriate permissions to the Google Cloud
Healthcare Service Agent.
*
+ * <p>ExportGcs This is to export FHIR resources from a FHIR store to Google
Cloud Storage. The
Review comment:
Good point. The reason I want to keep this as ExportGcs is there is also
an ExportBQ. I agree that both are implementation details, but depending on
usage, users may want a workflow connect to BQ. So I prefer to keep it this way
for future extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
