trucleduc commented on a change in pull request #12721:
URL: https://github.com/apache/beam/pull/12721#discussion_r482968032
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -122,12 +124,24 @@
* store) This requires each resource to contain a client provided ID. It is
important that when
* using import you give the appropriate permissions to the Google Cloud
Healthcare Service Agent.
*
+ * <p>ExportGcs This is to export FHIR resources from a FHIR store to Google
Cloud Storage. The
Review comment:
I see your point. That makes sense for this implementation because we
will read the resources back anyway. However, export FHIR resources to BigQuery
allows users to specify different schema, which could be non-trivial for
BigqueryIO to reproduce.
I made the change anyway and if there is a need like above, we can add the
ExportBQ later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
